Re: [Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver.

[Gerd Hoffmann]

  Hi,

>> +static QEMUCursor                 *ptr_cursor;
>> +static pixman_image_t             *ptr_image;
>> +static int                        ptr_refresh;
>> +static int                        px, py, pw, ph;
>> +static int                        mx, my, mon;
>> +
>> +/* options */
>> +static int                        use_scale;
>> +static pixman_filter_t            pfilter = PIXMAN_FILTER_GOOD;
> 
> Should stick all of this within a structure and pass it around where
> possible.

Don't see what this buys us as there can be only a single framebuffer
display anyway.  Can do that though.

>> +            if (qemu_console_is_graphic(NULL)) {
>> +                send_scancode(keycode, up);
>> +            } else if (!up) {
>> +                send_keysym(keycode, shift);
> 
> I'm confused here...  Why can't use use the normal keymap code with the
> keycode value?

keycode != keycode.  qemu uses ps/2 keycodes.  fbdev gets linux input
layer keycodes as input.

cheers,
  Gerd