Re: [Qemu-devel] [PATCH] ide-test: fix failure for test_flush

[Kevin Wolf]

Am 10.06.2013 um 20:23 hat Michael Roth geschrieben:
> bd07684aacfb61668ae2c25b7dd00b64f3d7c7f3 added a test to ensure BSY
> flag is set when a flush request is in flight. It does this by setting
> a blkdebug breakpoint on flush_to_os before issuing a CMD_FLUSH_CACHE.
> It then resumes CMD_FLUSH_CACHE operation and checks that BSY is unset.
> 
> The actual unsetting of BSY does not occur until ide_flush_cb gets
> called in a bh, however, so in some cases this check will race with
> the actual completion.
> 
> Fix this by polling the ide status register until BSY flag gets unset
> before we do our final sanity checks. According to
> f68ec8379e88502b4841a110c070e9b118d3151c this is in line with how a guest
> would determine whether or not the device is still busy.
> 
> Signed-off-by: Michael Roth <address@hidden>

Thanks, applied to the block branch.

Kevin