[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect |
Date: |
Tue, 11 Jun 2013 13:39:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 |
"parameter"
Am 11.06.2013 07:15, schrieb liguang:
> type last parameter of vnc_connect if bool,
"Type of last ...", "is"
> so pass 'false' instead of '0' for it.
>
> Signed-off-by: liguang <address@hidden>
Michael, can you fix those up? Then,
Reviewed-by: Andreas Färber <address@hidden>
Thanks,
Andreas
> ---
> ui/vnc.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index dfc7459..7d22660 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -3283,7 +3283,7 @@ void vnc_display_open(DisplayState *ds, const char
> *display, Error **errp)
> if (csock < 0) {
> goto fail;
> }
> - vnc_connect(vs, csock, 0, 0);
> + vnc_connect(vs, csock, 0, false);
> } else {
> /* listen for connects */
> char *dpy;
> @@ -3345,5 +3345,5 @@ void vnc_display_add_client(DisplayState *ds, int
> csock, int skipauth)
> {
> VncDisplay *vs = vnc_display;
>
> - vnc_connect(vs, csock, skipauth, 0);
> + vnc_connect(vs, csock, skipauth, false);
> }
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect, liguang, 2013/06/11
- [Qemu-devel] [PATCH 2/5] vnc: pass bool parameter for vnc_listen_read, liguang, 2013/06/11
- [Qemu-devel] [PATCH 3/5] qemu-char: pass bool parameter for qemu_opt_get_bool, liguang, 2013/06/11
- [Qemu-devel] [PATCH 4/5] memory: use '=' instead of '|=' for memory_region_update_pending, liguang, 2013/06/11
- [Qemu-devel] [PATCH 5/5] sd: pass bool parameter for sd_init, liguang, 2013/06/11
- Re: [Qemu-devel] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect,
Andreas Färber <=
- Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/5] vnc: pass bool pararmeter for vnc_connect, Michael Tokarev, 2013/06/11