[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] qcow2: Options to enable discard for freed
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/5] qcow2: Options to enable discard for freed clusters |
|
Date: |
Thu, 13 Jun 2013 18:10:12 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 13/06/2013 07:47, Kevin Wolf ha scritto:
> + s->discard_passthrough[QCOW2_DISCARD_NEVER] = false,
> + s->discard_passthrough[QCOW2_DISCARD_ALWAYS] = true,
> + s->discard_passthrough[QCOW2_DISCARD_REQUEST] =
> + qemu_opt_get_bool(opts, QCOW2_OPT_DISCARD_REQUEST,
> + flags & BDRV_O_UNMAP),
I think there should not be two ways to enable it, it is confusing.
> + s->discard_passthrough[QCOW2_DISCARD_SNAPSHOT] =
> + qemu_opt_get_bool(opts, QCOW2_OPT_DISCARD_SNAPSHOT, true),
> + s->discard_passthrough[QCOW2_DISCARD_OTHER] =
> + qemu_opt_get_bool(opts, QCOW2_OPT_DISCARD_OTHER, false),
Please document the defaults in qcow2_runtime_opts. (BTW, what is the
rationale?)
Paolo
Re: [Qemu-devel] [PATCH 3/5] qcow2: Options to enable discard for freed clusters, Stefan Hajnoczi, 2013/06/17
[Qemu-devel] [PATCH 2/5] qcow2: Add refcount update reason to all callers, Kevin Wolf, 2013/06/13
[Qemu-devel] [PATCH 4/5] qcow2: Batch discards, Kevin Wolf, 2013/06/13
[Qemu-devel] [PATCH 5/5] block: Always enable discard on the protocol level, Kevin Wolf, 2013/06/13