[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] fbdev: add monitor command to enable/disabl
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] fbdev: add monitor command to enable/disable |
Date: |
Sat, 15 Jun 2013 16:19:57 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
On 06/06/2013 04:37 PM, Gerd Hoffmann wrote:
> This patch adds a fbdev monitor command to enable/disable
> the fbdev display at runtime to both qmp and hmp.
>
> qmp: framebuffer-display enable=on|off scale=on|off device=/dev/fb<n>
> hmp: framebuffer-display on|off
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> +++ b/qapi-schema.json
> @@ -3618,3 +3618,23 @@
> '*cpuid-input-ecx': 'int',
> 'cpuid-register': 'X86CPURegister32',
> 'features': 'int' } }
> +
> +##
> +# @framebuffer-display:
> +#
> +# Enable/disable linux console framebuffer display.
> +#
> +# @enable: whenever the framebuffer display should be enabled or disabled.
s/whenever/whether/
> +#
> +# @scale: #optional enables display scaling, default: off
> +#
> +# @device: #optional specifies framebuffer device, default: /dev/fb0
> +#
> +# Returns: Nothing.
> +#
> +# Since: 1.6
> +#
> +##
> +{ 'command': 'framebuffer-display', 'data': {'enable' : 'bool',
> + '*scale' : 'bool',
> + '*device' : 'str' } }
I'm not a fan of write-only interfaces. Where is the corresponding
query- command that tells me the current settings?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver., Gerd Hoffmann, 2013/06/06
- [Qemu-devel] [PATCH 1/2] fbdev: add linux framebuffer display driver., Gerd Hoffmann, 2013/06/26
- [Qemu-devel] [PATCH 2/2] fbdev: add monitor commands to enable/disable/query, Gerd Hoffmann, 2013/06/26
- Re: [Qemu-devel] [PATCH 2/2] fbdev: add monitor commands to enable/disable/query, Luiz Capitulino, 2013/06/26
- Re: [Qemu-devel] [PATCH 2/2] fbdev: add monitor commands to enable/disable/query, Gerd Hoffmann, 2013/06/27
- Re: [Qemu-devel] [PATCH 2/2] fbdev: add monitor commands to enable/disable/query, Luiz Capitulino, 2013/06/27
- Re: [Qemu-devel] [PATCH 2/2] fbdev: add monitor commands to enable/disable/query, Eric Blake, 2013/06/27
- Re: [Qemu-devel] [PATCH 2/2] fbdev: add monitor commands to enable/disable/query, Luiz Capitulino, 2013/06/28