[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/7] sheepdog: fix snapshot tag initialization
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PULL 1/7] sheepdog: fix snapshot tag initialization |
Date: |
Mon, 17 Jun 2013 18:31:44 +0200 |
From: Liu Yuan <address@hidden>
This is an old and obvious bug. We should pass snapshot_id to the
tag. Or simple command like 'qemu-img snapshot -a tag sheepdog:image' will fail
Cc: address@hidden
Cc: MORITA Kazutaka <address@hidden>
Cc: Kevin Wolf <address@hidden>
Cc: Stefan Hajnoczi <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Signed-off-by: Liu Yuan <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
block/sheepdog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 21a4edf..94218ac 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -2063,7 +2063,7 @@ static int sd_snapshot_goto(BlockDriverState *bs, const
char *snapshot_id)
if (snapid) {
tag[0] = 0;
} else {
- pstrcpy(tag, sizeof(tag), s->name);
+ pstrcpy(tag, sizeof(tag), snapshot_id);
}
ret = reload_inode(s, snapid, tag);
--
1.8.1.4
- [Qemu-devel] [PULL 0/7] Block patches, Kevin Wolf, 2013/06/17
- [Qemu-devel] [PULL 2/7] sheepdog: support 'qemu-img snapshot -a', Kevin Wolf, 2013/06/17
- [Qemu-devel] [PULL 1/7] sheepdog: fix snapshot tag initialization,
Kevin Wolf <=
- [Qemu-devel] [PULL 4/7] vmdk: byteswap VMDK4Header.desc_offset field, Kevin Wolf, 2013/06/17
- [Qemu-devel] [PULL 5/7] curl: Don't set curl options on the handle just before it's going to be deleted., Kevin Wolf, 2013/06/17
- [Qemu-devel] [PULL 3/7] block/curl.c: Refuse to open the handle for writes., Kevin Wolf, 2013/06/17
- [Qemu-devel] [PULL 7/7] vmdk: Allow reading variable size descriptor files, Kevin Wolf, 2013/06/17
- [Qemu-devel] [PULL 6/7] NVMe: Initial commit for new storage interface, Kevin Wolf, 2013/06/17
- Re: [Qemu-devel] [PULL 0/7] Block patches, Anthony Liguori, 2013/06/17