Re: [Qemu-devel] [PATCH 1/7] migration: export MIG_STATE_xxx flags

[Lei Li]

On 06/17/2013 12:01 AM, Anthony Liguori wrote:
> Lei Li <address@hidden> writes:
>
> > Signed-off-by: Lei Li <address@hidden>
> > ---
> >   include/migration/migration.h |    8 ++++++++
> >   migration.c                   |    8 --------
> >   2 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/include/migration/migration.h b/include/migration/migration.h
> > index e2acec6..8866c3c 100644
> > --- a/include/migration/migration.h
> > +++ b/include/migration/migration.h
> > @@ -22,6 +22,14 @@
> >   #include "migration/vmstate.h"
> >   #include "qapi-types.h"
> >   
> > +enum {
> > +    MIG_STATE_ERROR,
> > +    MIG_STATE_SETUP,
> > +    MIG_STATE_CANCELLED,
> > +    MIG_STATE_ACTIVE,
> > +    MIG_STATE_COMPLETED,
> > +};
> > +
> If these flags are being exported, it would be nice to provide comments
> describing what each state corresponded to.

Got it, thanks.

> Regards,
>
> Anthony Liguori
>
> >   struct MigrationParams {
> >       bool blk;
> >       bool shared;
> > diff --git a/migration.c b/migration.c
> > index 058f9e6..0921ace 100644
> > --- a/migration.c
> > +++ b/migration.c
> > @@ -35,14 +35,6 @@
> >       do { } while (0)
> >   #endif
> >   
> > -enum {
> > -    MIG_STATE_ERROR,
> > -    MIG_STATE_SETUP,
> > -    MIG_STATE_CANCELLED,
> > -    MIG_STATE_ACTIVE,
> > -    MIG_STATE_COMPLETED,
> > -};
> > -
> >   #define MAX_THROTTLE  (32 << 20)      /* Migration speed throttling */
> >   
> >   /* Amount of time to allocate to each "chunk" of bandwidth-throttled
> > --
> > 1.7.7.6


--
Lei