[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] extend the macaddr space to 0xffffffff
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] extend the macaddr space to 0xffffffff |
Date: |
Tue, 18 Jun 2013 09:19:31 +0300 |
On Tue, Jun 18, 2013 at 09:51:44AM +0800, Amos Kong wrote:
> On Mon, Jun 17, 2013 at 05:04:03PM +0300, Michael S. Tsirkin wrote:
> > On Mon, Jun 17, 2013 at 09:35:11PM +0800, Amos Kong wrote:
> > > Currently we only support to allocate 0xff mac-addresses,
> > > if we start guest by pci-bridge/multiple-func, the macaddr
> > > are not enough.
> > >
> > > This patch extends the mac-address space to 0xffffffff
> > >
> > > 52:54:00:00:00:00 ~ 52:54:ff:ff:ff:ff
> > >
> > > Signed-off-by: Amos Kong <address@hidden>
> >
> >
> > And then there's even more chance a user error
> > (forgot to specify mac) will lead to broken
> > LANs because of collisions.
> >
> > Why is it that whoever wants >256 NICs can't just
> > specify the addresses explicitly?
>
> We should lead user to use assigned mac, those two patches
> are just considered for the lazy users ;)
Let's just fail address allocation once the low byte overflows.
If you want >256 NICs, specify MAC addresses.
>
> --
> Amos.
Re: [Qemu-devel] [PATCH 0/2] fix macaddr allocation, Stefan Hajnoczi, 2013/06/18