Re: [Qemu-devel] [PULL 06/10] configure: dtc: Probe for libfdt_env.h

[Peter Maydell]

On 18 June 2013 01:46, Andreas Färber <address@hidden> wrote:
> $ make -j6 V=1

> make -I/home/andreas/QEMU/qemu-ppc/dtc
> VPATH=/home/andreas/QEMU/qemu-ppc/dtc -C dtc V="1"
> LIBFDT_srcdir=/home/andreas/QEMU/qemu-ppc/dtc/libfdt CFLAGS="-O2
> -D_FORTIFY_SOURCE=2 -g  -Werror -fPIE -DPIE -m64 -D_GNU_SOURCE
> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes
> -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes
> -fno-strict-aliasing  -Wendif-labels -Wmissing-include-dirs -Wempty-body
> -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self
> -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition
> -Wtype-limits -fstack-protector-all -I/usr/include/libseccomp-1.0.1
> -I/usr/include/libpng15   -I/usr/include/spice-server
> -I/usr/include/pixman-1 -I/usr/include/spice-1   -I/usr/include/pixman-1
>   -I/home/andreas/QEMU/qemu-ppc/dtc/libfdt -pthread
> -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include
> -I/home/andreas/QEMU/qemu-ppc/tests -I/home/andreas/QEMU/build-ppc/dtc
> -I/home/andreas/QEMU/qemu-ppc/dtc
> -I/home/andreas/QEMU/qemu-ppc/dtc/libfdt" LDFLAGS="-Wl,--warn-common
> -Wl,-z,relro -Wl,-z,now -pie -m64 -g " ARFLAGS="" CC="cc" AR="ar"
> LD="ld"  BUILD_DIR=/home/andreas/QEMU/build-ppc libfdt/libfdt.a

...so we tell the libfdt makefile to build libfdt.a...

> make[1]: Entering directory `/home/andreas/QEMU/build-ppc/dtc'
> cc -I libfdt -MM -MG -MT "tests/trees.o tests/trees.d"
> /home/andreas/QEMU/qemu-ppc/dtc/tests/trees.S > tests/trees.d
> cc -I libfdt -MM -MG -MT "tests/dumptrees.o tests/dumptrees.d"

...and it starts to build its test suite?! This doesn't happen
for me. What git commit is your dtc submodule at, please?

However, it's not the cause of the problem:

> ar  libfdt/libfdt.a libfdt/fdt.o libfdt/fdt_ro.o libfdt/fdt_wip.o
> libfdt/fdt_sw.o libfdt/fdt_rw.o libfdt/fdt_strerror.o
> ar: two different operation options specified

...which is that the top level makefile is passing ARFLAGS=""
and so we don't specify any operation to ar at all. For me
the submake is invoked with ARFLAGS ="rv" (which is Make's
default for when ARFLAGS wasn't specified).

QEMU's configure and makefile don't fiddle with ARFLAGS at all:
are you passing some odd values in from your environment?

thanks
-- PMM