[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/scsi: Don't increment a boolean value
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] hw/scsi: Don't increment a boolean value |
|
Date: |
Tue, 18 Jun 2013 16:14:33 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 10/06/2013 22:24, Stefan Weil ha scritto:
> This fixes a warning from cppcheck.
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> hw/scsi/vmw_pvscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c
> index 48d12f4..446f723 100644
> --- a/hw/scsi/vmw_pvscsi.c
> +++ b/hw/scsi/vmw_pvscsi.c
> @@ -389,7 +389,7 @@ pvscsi_process_completion_queue(void *opaque)
> QTAILQ_REMOVE(&s->completion_queue, pvscsi_req, next);
> pvscsi_cmp_ring_put(s, &pvscsi_req->cmp);
> g_free(pvscsi_req);
> - has_completed++;
> + has_completed = true;
> }
>
> if (has_completed) {
>
Applied to scsi-next branch, thanks.
Paolo