[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 04/11] blockdev: drop redundant proto_drv che
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 04/11] blockdev: drop redundant proto_drv check |
|
Date: |
Wed, 19 Jun 2013 12:57:12 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 30.05.2013 um 14:34 hat Stefan Hajnoczi geschrieben:
> It is not necessary to check that we can find a protocol block driver
> since we create or open the image file. This produces the error that we
> need anyway.
>
> Besides, the QERR_INVALID_BLOCK_FORMAT is inappropriate since the
> protocol is incorrect rather than the format.
>
> Also drop an empty line between bdrv_open() and checking its return
> value. This may be due to copy-pasting from earlier code that performed
> other operations before handling errors.
>
> Reported-by: Kevin Wolf <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>