qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] libqtest: Plug fd and memory leaks in qtest


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 1/2] libqtest: Plug fd and memory leaks in qtest_quit()
Date: Wed, 19 Jun 2013 07:30:49 -0500
User-agent: Notmuch/0.15.2+77~g661dcf8 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu)

Markus Armbruster <address@hidden> writes:

> Signed-off-by: Markus Armbruster <address@hidden>

Reviewed-by: Anthony Liguori <address@hidden>

Regards,

Anthony Liguori

> ---
>  tests/libqtest.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/tests/libqtest.c b/tests/libqtest.c
> index 879ffe9..bb82069 100644
> --- a/tests/libqtest.c
> +++ b/tests/libqtest.c
> @@ -171,12 +171,16 @@ void qtest_quit(QTestState *s)
>          waitpid(pid, &status, 0);
>      }
>  
> +    close(s->fd);
> +    close(s->qmp_fd);
> +    g_string_free(s->rx, true);
>      unlink(s->pid_file);
>      unlink(s->socket_path);
>      unlink(s->qmp_socket_path);
>      g_free(s->pid_file);
>      g_free(s->socket_path);
>      g_free(s->qmp_socket_path);
> +    g_free(s);
>  }
>  
>  static void socket_sendf(int fd, const char *fmt, va_list ap)
> -- 
> 1.7.11.7




reply via email to

[Prev in Thread] Current Thread [Next in Thread]