qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] libqtest: New qtest_end() to go with qtest_


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 2/2] libqtest: New qtest_end() to go with qtest_start()
Date: Wed, 19 Jun 2013 15:21:34 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)

Andreas Färber <address@hidden> writes:

> Am 19.06.2013 09:44, schrieb Markus Armbruster:
[...]
>> diff --git a/tests/libqtest.h b/tests/libqtest.h
>> index 437bda3..329325b 100644
>> --- a/tests/libqtest.h
>> +++ b/tests/libqtest.h
>> @@ -17,6 +17,7 @@
>>  #ifndef LIBQTEST_H
>>  #define LIBQTEST_H
>>  
>> +#include <stddef.h>
>>  #include <stdint.h>
>>  #include <stdbool.h>
>>  #include <stdarg.h>
>> @@ -318,6 +319,12 @@ static inline QTestState *qtest_start(const char *args)
>>      return global_qtest;
>>  }
>>  
>> +static inline void qtest_end(void)
>> +{
>> +    qtest_quit(global_qtest);
>> +    global_qtest = NULL;
>> +}
>> +
>>  /**
>>   * qmp:
>>   * @fmt...: QMP message to send to qemu
>> 
>
> Function and usage looks fine, but please add a gtk-doc comment.
> qtest_start() does have one.

Oversight, will fix, thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]