[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/12] spapr-vio: pass type to spapr_vio_find_by
|
From: |
Anthony Liguori |
|
Subject: |
Re: [Qemu-devel] [PATCH 11/12] spapr-vio: pass type to spapr_vio_find_by_reg() |
|
Date: |
Wed, 19 Jun 2013 16:56:24 -0500 |
|
User-agent: |
Notmuch/0.15.2+77~g661dcf8 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Alexander Graf <address@hidden> writes:
> On 19.06.2013, at 22:40, Anthony Liguori wrote:
>
>> Today if an invalid hcall is made to an otherwise valid device we
>> abort due to QOM casting. This adds a parameter to find_by_reg()
>> to indicate which type of device we're looking for.
>
> This should also adjust the hack to only match reg=0 for
> TYPE_VIO_SPAPR_VTY_DEVICE, no?
Yup, that'll result in a bad cast otherwise. Nice catch.
I'll respin.
Regards,
Anthony Liguori
>
>
> Alex
- [Qemu-devel] [PATCH 10/12] spapr-vty: refactor the code to improve consistency, (continued)
- [Qemu-devel] [PATCH 10/12] spapr-vty: refactor the code to improve consistency, Anthony Liguori, 2013/06/19
- [Qemu-devel] [PATCH 04/12] qtest: add interface to save/restore, Anthony Liguori, 2013/06/19
- [Qemu-devel] [PATCH 07/12] spapr-rtas: add CPU argument to RTAS calls, Anthony Liguori, 2013/06/19
- [Qemu-devel] [PATCH 11/12] spapr-vio: pass type to spapr_vio_find_by_reg(), Anthony Liguori, 2013/06/19
- [Qemu-devel] [PATCH 05/12] spapr-vty: add qtest test case, Anthony Liguori, 2013/06/19
- [Qemu-devel] [PATCH 02/12] qtest: add spapr hypercall support, Anthony Liguori, 2013/06/19