Re: [Qemu-devel] [PATCH 3/7] NUMA: parse guest numa nodes memory policy

[Wanlong Gao]

On 06/20/2013 01:39 AM, Paolo Bonzini wrote:
> Il 19/06/2013 10:01, Wanlong Gao ha scritto:
>> On 06/19/2013 04:19 AM, Bandan Das wrote:
>>> Eduardo Habkost <address@hidden> writes:
>>>
>>>> On Tue, Jun 18, 2013 at 11:20:37AM +0200, Paolo Bonzini wrote:
>>>> [...]
>>>>> Also, please use QemuOpts instead of yet another homegrown parser.
>>>>> Eduardo, I think you had the most recent attempt to convert -numa to
>>>>> QemuOpts?
>>>>
>>>> I had one, but I believe it is more complex than it should have been. I
>>>> was creating a "numa-node" config section while keeping "-numa" just for
>>>> compatbility, but I don't think we really need to do that.
>>>
>>> Ah, I was working on an update to Eduardo's earlier proposals for multiple 
>>> CPU ranges
>>> and part of the change was to convert to QemuOpts. 
>>>
>>> Probably needs more testing but posted it anyway since we are already 
>>> discussing this :
>>> [PATCH v3] vl.c: Support multiple CPU ranges on -numa option
>>> (hasn't shown up in the archives yet)
>>
>> Here is the archive: http://thread.gmane.org/gmane.comp.emulators.qemu/217491
>>
>> So, are you all ACK with this? And we are not considering compatible thing 
>> by using
>> "cpu" instead of "cpus" here?
> 
> No; as Eduardo pointed out, the "cpus" must be kept.  But apart from
> that, picking up Bandan's patch in v2 of this series should be fine.

Got it, thank you.

Regards,
Wanlong Gao

> 
> Paolo
> 
>