[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/2] pvpanic: initialization cleanup
|
From: |
Stefano Stabellini |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 1/2] pvpanic: initialization cleanup |
|
Date: |
Thu, 20 Jun 2013 11:54:56 +0100 |
|
User-agent: |
Alpine 2.02 (DEB 1266 2009-07-14) |
On Wed, 19 Jun 2013, Michael S. Tsirkin wrote:
> -int pvpanic_init(ISABus *bus)
> +void pvpanic_init(ISABus *bus)
> {
> - isa_create_simple(bus, TYPE_ISA_PVPANIC_DEVICE);
> - return 0;
> + ISADevice *dev;
> + FWCfgState *fw_cfg = fw_cfg_find();
> + if (!fw_cfg) {
> + return;
> + }
> + dev = isa_create_simple (bus, TYPE_ISA_PVPANIC_DEVICE);
> + pvpanic_fw_cfg(dev, fw_cfg);
> }
looks OK to me