[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] qapi-schema: Use BlockdevSnapshot type for
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync |
Date: |
Fri, 21 Jun 2013 11:31:28 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
On 06/19/2013 05:28 PM, Kevin Wolf wrote:
> We don't have to duplicate the definition any more now that we may refer
> to a type instead.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> qapi-schema.json | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index a80ee40..ee19d6a 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1669,8 +1669,7 @@
> # Since 0.14.0
> ##
> { 'command': 'blockdev-snapshot-sync',
> - 'data': { 'device': 'str', 'snapshot-file': 'str', '*format': 'str',
> - '*mode': 'NewImageMode'} }
> + 'data': 'BlockdevSnapshot' }
There's still duplication of the doc comments, but as we don't have
anything parsing doc comments to convert them into a more usable form
yet, that can be something we worry about later.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature