[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH 09/13] qemu-char: use ChardevBack
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH 09/13] qemu-char: use ChardevBackendKind in in CharDriver |
Date: |
Fri, 21 Jun 2013 22:36:20 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130529 Icedove/17.0.5 |
21.06.2013 14:38, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> qemu-char.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 5751391..1c0903f 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -3127,7 +3127,7 @@ typedef struct CharDriver {
> /* old, pre qapi */
> CharDriverState *(*open)(QemuOpts *opts);
> /* new, qapi-based */
> - int kind;
> + ChardevBackendKind kind;
> void (*parse)(QemuOpts *opts, ChardevBackend *backend, Error **errp);
> } CharDriver;
How about switching argument of register_char_driver_qapi() to the same
type as well?
Thanks,
/mjt
- [Qemu-devel] [PATCH 01/13] qemu-socket: zero-initialize SocketAddress, (continued)
- [Qemu-devel] [PATCH 01/13] qemu-socket: zero-initialize SocketAddress, Gerd Hoffmann, 2013/06/21
- [Qemu-devel] [PATCH 04/13] qemu-char: check optional fields using has_*, Gerd Hoffmann, 2013/06/21
- [Qemu-devel] [PATCH 03/13] qemu-socket: catch monitor_get_fd failures, Gerd Hoffmann, 2013/06/21
- [Qemu-devel] [PATCH 02/13] qemu-socket: drop pointless allocation, Gerd Hoffmann, 2013/06/21
- [Qemu-devel] [PATCH 06/13] qemu-char: print notification to stderr, Gerd Hoffmann, 2013/06/21
- [Qemu-devel] [PATCH 05/13] qemu-char: use more specific error_setg_* variants, Gerd Hoffmann, 2013/06/21
- [Qemu-devel] [PATCH 07/13] qemu-char: fix documentation for telnet+wait socket flags, Gerd Hoffmann, 2013/06/21
- [Qemu-devel] [PATCH 09/13] qemu-char: use ChardevBackendKind in in CharDriver, Gerd Hoffmann, 2013/06/21
- Re: [Qemu-devel] [Qemu-trivial] [PATCH 09/13] qemu-char: use ChardevBackendKind in in CharDriver,
Michael Tokarev <=
- [Qemu-devel] [PATCH 11/13] qemu-char: add -chardev mux support, Gerd Hoffmann, 2013/06/21
- [Qemu-devel] [PATCH 08/13] qemu-char: don't leak opts on error, Gerd Hoffmann, 2013/06/21
- [Qemu-devel] [PATCH 10/13] qemu-char: minor mux chardev fixes, Gerd Hoffmann, 2013/06/21
- [Qemu-devel] [PATCH 13/13] qemu-socket: don't leak opts on error, Gerd Hoffmann, 2013/06/21
- [Qemu-devel] [PATCH 12/13] qemu-char: report udb backend errors, Gerd Hoffmann, 2013/06/21
- Re: [Qemu-devel] [Qemu-trivial] [PATCH 00/13] A bunch of little socket + chardev fixes, Michael Tokarev, 2013/06/21