[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Switch the roles of jmp_next[0] and jmp_next[1]
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] Switch the roles of jmp_next[0] and jmp_next[1]. |
|
Date: |
Sat, 22 Jun 2013 23:04:02 +0100 |
On 22 June 2013 17:10, Zhihui Zhang <address@hidden> wrote:
> This way, jmp_next[0] means "taken" for both conditional jumps AND
> unconditional jumps.
> Currently, it has opposite meanings for the two cases.
This commit message is missing a rationale: do you want
to do this because:
* it fixes a bug? (if so, what bug)
* it is more efficient? (if so, some description of why)
* you just think it would be neater this way around?
How about the TB exit via gen_jz_ecx_string ?
thanks
-- PMM