[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 22/23] block: Always enable discard on the protocol
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 22/23] block: Always enable discard on the protocol level |
Date: |
Mon, 24 Jun 2013 11:10:34 +0200 |
From: Kevin Wolf <address@hidden>
Turning on discard options in qcow2 doesn't help a lot when the discard
requests that it issues are thrown away by the raw-posix layer. This
patch always enables discard functionality on the protocol level so that
it's the image format's responsibility to send (or not) discard
requests. Requests sent by the guest will be allowed or ignored by the
top level BlockDriverState, which depends on the discard=... option like
before.
In particular, this means that even without specifying options, the
qcow2 default of discarding deleted snapshots actually takes effect now,
both for qemu and qemu-img.
Signed-off-by: Kevin Wolf <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block.c b/block.c
index b88ad2f..8e77d46 100644
--- a/block.c
+++ b/block.c
@@ -1045,7 +1045,7 @@ int bdrv_open(BlockDriverState *bs, const char *filename,
QDict *options,
extract_subqdict(options, &file_options, "file.");
ret = bdrv_file_open(&file, filename, file_options,
- bdrv_open_flags(bs, flags));
+ bdrv_open_flags(bs, flags | BDRV_O_UNMAP));
if (ret < 0) {
goto fail;
}
--
1.8.1.4
- [Qemu-devel] [PATCH 13/23] ide: Convert SEEK to ide_cmd_table handler, (continued)
- [Qemu-devel] [PATCH 13/23] ide: Convert SEEK to ide_cmd_table handler, Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 14/23] ide: Convert ATAPI commands to ide_cmd_table handler, Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 15/23] ide: Convert CF-ATA commands to ide_cmd_table handler, Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 16/23] ide: Convert SMART commands to ide_cmd_table handler, Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 17/23] ide: Clean up ide_exec_cmd(), Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 18/23] Revert "block: Disable driver-specific options for 1.5", Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 19/23] qcow2: Add refcount update reason to all callers, Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 20/23] qcow2: Options to enable discard for freed clusters, Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 23/23] vmdk: refuse to open higher version than supported, Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 21/23] qcow2: Batch discards, Stefan Hajnoczi, 2013/06/24
- [Qemu-devel] [PATCH 22/23] block: Always enable discard on the protocol level,
Stefan Hajnoczi <=