Re: [Qemu-devel] [PATCH 22/23] bsd-user: add more strace formating

[Peter Maydell]

On 24 June 2013 03:03, Stacey Son <address@hidden> wrote:
> This change add more strace formating for popular system calls.  It also
> separates out *BSD and architecture dependent code.  In addition, it
> changes TARGET_OS in configure (and in the associated makefiles) to
> what it should really be: HOST_OS.

You introduced TARGET_OS in the first place. Please don't put
code in in one patch and then change it in a later one; rearrange
your patchset to avoid this.

This patch is also doing too many things at once.

> +if [ "$HOST_ABI_DIR" != "" ]; then
> +    echo "HOST_ABI_DIR=$HOST_ABI_DIR" >> $config_target_mak
> +fi

Host specific definitions in the target config? Doesn't look right.

-- PMM