Re: [Qemu-devel] [PATCH V2] build: remove compile warning

[Stefan Weil]

Am 24.06.2013 16:44, schrieb Paolo Bonzini:
> Il 22/06/2013 12:03, Stefan Weil ha scritto:
>> I get this warning, too, when I run a normal cross compilation with
>> MinGW-w64:
>>
>> util/iov.c:190:33: warning: ‘orig_len’ may be used uninitialized in this
>> function [-Wuninitialized]
>>
>> My build environment:
>>
>> Debian wheezy with packages gcc-mingw-w64-i686, gcc-mingw-w64-x86-64
>> (4.6.3-14+8).
>>
>> A complete build results in 5 warnings. Here are the other 4 of them:
>>
>> hw/arm/spitz.c:280:0: warning: "MOD_SHIFT" redefined [enabled by default]
>> hw/ppc/spapr.c:673:26: warning: cast from pointer to integer of
>> different size [-Wpointer-to-int-cast]
> Isn't this one a Win64 bug?

Yes. http://patchwork.ozlabs.org/patch/252666/ fixes it.

>> hw/ppc/spapr_hcall.c:188:1: warning: control reaches end of non-void
>> function [-Wreturn-type]
>> hw/ppc/spapr_pci.c:454:1: warning: control reaches end of non-void
>> function [-Wreturn-type]
> I think you could report this to mingw.  GCC should handle "if (!0)
> foo()" just fine if foo is noreturn, perhaps the "assertion failure"
> runtime function is not noreturn in mingw.

It's a gcc problem. Removing the assertion manually in the source
code and compiling with NDEBUG (which we do by default)results
in the same compiler warning.

I have sent a small patch series which fixes both warnings and
which hopefully matches your criteria for acceptable code changes :-)

See http://patchwork.ozlabs.org/patch/253937/ and two more.

Regards
Stefan