qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of t


From: Peter Maydell
Subject: Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer.
Date: Tue, 25 Jun 2013 21:53:28 +0100

On 25 June 2013 19:42, Paolo Bonzini <address@hidden> wrote:
> Il 25/06/2013 20:21, Peter Maydell ha scritto:
>> @@ -416,7 +513,7 @@ static int imx_timerg_init(SysBusDevice *dev)
>>
>>      sysbus_init_irq(dev, &s->irq);
>>      memory_region_init_io(&s->iomem, &imx_timerg_ops,
>> -                          s, "imxg-timer",
>> +                          s, TYPE_IMX_GPT,
>>                            0x00001000);
>>      sysbus_init_mmio(dev, &s->iomem);
>>
>
> There was some agreement that this is not a good change.

I agree (and more so regarding the use of the macro in the
vmstate name), but nobody actually posted any comment to
that effect against any of the versions of this patch that
got sent out for review...

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]