[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH V3 5/9] qmp: add interface blockdev-snapshot-interna
From: |
Wenchao Xia |
Subject: |
[Qemu-devel] [PATCH V3 5/9] qmp: add interface blockdev-snapshot-internal-sync |
Date: |
Thu, 27 Jun 2013 10:41:44 +0800 |
Snapshot ID can't be specified in this interface.
Signed-off-by: Wenchao Xia <address@hidden>
---
blockdev.c | 13 +++++++++++++
qapi-schema.json | 22 ++++++++++++++++++++++
qmp-commands.hx | 30 ++++++++++++++++++++++++++++++
3 files changed, 65 insertions(+), 0 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index c3b607d..ce89f83 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -777,6 +777,19 @@ void qmp_blockdev_snapshot_sync(const char *device, const
char *snapshot_file,
&snapshot, errp);
}
+void qmp_blockdev_snapshot_internal_sync(const char *device,
+ const char *name,
+ Error **errp)
+{
+ BlockdevSnapshotInternal snapshot = {
+ .device = (char *) device,
+ .name = (char *) name
+ };
+
+ blockdev_do_action(TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_INTERNAL_SYNC,
+ &snapshot, errp);
+}
+
/* New and old BlockDriverState structs for group snapshots */
diff --git a/qapi-schema.json b/qapi-schema.json
index 2547a7d..fba9b15 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -1738,6 +1738,28 @@
'*mode': 'NewImageMode'} }
##
+# @blockdev-snapshot-internal-sync
+#
+# Synchronously take an internal snapshot of a block device, when the format
+# of the image used supports it.
+#
+# @device: the name of the device to generate the snapshot from
+#
+# @name: the name of new snapshot name
+#
+# Returns: nothing on success
+# If @device is not a valid block device, DeviceNotFound
+# If any snapshot matching @name exists, or the name string is invalid
+# which may mess up with snapshot ID, or name is empty, GenericError
+# If the format of the image used does not support it,
+# BlockFormatFeatureNotSupported
+#
+# Since 1.6
+##
+{ 'command': 'blockdev-snapshot-internal-sync',
+ 'data': { 'device': 'str', 'name': 'str'} }
+
+##
# @human-monitor-command:
#
# Execute a command on the human monitor and return the output.
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 27642c0..3df50de 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -1091,6 +1091,36 @@ Example:
EQMP
{
+ .name = "blockdev-snapshot-internal-sync",
+ .args_type = "device:B,name:s",
+ .mhandler.cmd_new = qmp_marshal_input_blockdev_snapshot_internal_sync,
+ },
+
+SQMP
+blockdev-snapshot-internal-sync
+-------------------------------
+
+Synchronously take an internal snapshot of a block device when the format of
+image used supports it. If the name is a numeric string which may mess up with
+ID, such as "19", or an empty string, the operation will fail. If a snapshot
+with name already exists, the operation will fail.
+
+Arguments:
+
+- "device": device name to snapshot (json-string)
+- "name": name of the new snapshot (json-string)
+
+Example:
+
+-> { "execute": "blockdev-snapshot-internal-sync",
+ "arguments": { "device": "ide-hd0",
+ "name": "snapshot0" }
+ }
+<- { "return": {} }
+
+EQMP
+
+ {
.name = "drive-mirror",
.args_type = "sync:s,device:B,target:s,speed:i?,mode:s?,format:s?,"
"on-source-error:s?,on-target-error:s?,"
--
1.7.1
- [Qemu-devel] [PATCH V3 0/9] add internal snapshot support at block device level, Wenchao Xia, 2013/06/25
- [Qemu-devel] [PATCH V3 1/9] snapshot: new function bdrv_snapshot_find_by_id_and_name(), Wenchao Xia, 2013/06/25
- [Qemu-devel] [PATCH V3 2/9] snapshot: add paired functions for internal snapshot id and name, Wenchao Xia, 2013/06/25
- [Qemu-devel] [PATCH V3 3/9] snapshot: distinguish id and name in snapshot delete, Wenchao Xia, 2013/06/25
- [Qemu-devel] [PATCH V3 4/9] qmp: add internal snapshot support in qmp_transaction, Wenchao Xia, 2013/06/25
- [Qemu-devel] [PATCH V3 5/9] qmp: add interface blockdev-snapshot-internal-sync,
Wenchao Xia <=
- [Qemu-devel] [PATCH V3 6/9] qmp: add interface blockdev-snapshot-delete-internal-sync, Wenchao Xia, 2013/06/25
- [Qemu-devel] [PATCH V3 7/9] hmp: add interface hmp_snapshot_blkdev_internal, Wenchao Xia, 2013/06/25
- [Qemu-devel] [PATCH V3 8/9] hmp: add interface hmp_snapshot_delete_blkdev_internal, Wenchao Xia, 2013/06/25
- [Qemu-devel] [PATCH V3 9/9] qemu-iotests: add 056 internal snapshot for block device test case, Wenchao Xia, 2013/06/25