[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of t
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer. |
Date: |
Wed, 26 Jun 2013 08:56:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 25/06/2013 22:53, Peter Maydell ha scritto:
> On 25 June 2013 19:42, Paolo Bonzini <address@hidden> wrote:
>> Il 25/06/2013 20:21, Peter Maydell ha scritto:
>>> @@ -416,7 +513,7 @@ static int imx_timerg_init(SysBusDevice *dev)
>>>
>>> sysbus_init_irq(dev, &s->irq);
>>> memory_region_init_io(&s->iomem, &imx_timerg_ops,
>>> - s, "imxg-timer",
>>> + s, TYPE_IMX_GPT,
>>> 0x00001000);
>>> sysbus_init_mmio(dev, &s->iomem);
>>>
>>
>> There was some agreement that this is not a good change.
>
> I agree (and more so regarding the use of the macro in the
> vmstate name), but nobody actually posted any comment to
> that effect against any of the versions of this patch that
> got sent out for review...
Yeah, the timing was bad... Can you post a revert, though?
Paolo
- [Qemu-devel] [PULL 0/8] arm-devs queue, Peter Maydell, 2013/06/25
- [Qemu-devel] [PULL 1/8] ARM: Allow dumping of device tree, Peter Maydell, 2013/06/25
- [Qemu-devel] [PULL 8/8] nand: Don't inherit from Sysbus, Peter Maydell, 2013/06/25
- [Qemu-devel] [PULL 7/8] block/nand: Convert Sysbus::init to Device::realize, Peter Maydell, 2013/06/25
- [Qemu-devel] [PULL 3/8] i.MX: Rework functions/types name and use new style initialization, Peter Maydell, 2013/06/25
- [Qemu-devel] [PULL 4/8] arm/boot: Free dtb blob memory after use, Peter Maydell, 2013/06/25
- [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., Peter Maydell, 2013/06/25
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., Peter Crosthwaite, 2013/06/26
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., Jean-Christophe DUBOIS, 2013/06/26
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., Jean-Christophe DUBOIS, 2013/06/26
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., Paolo Bonzini, 2013/06/26
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., Jean-Christophe DUBOIS, 2013/06/26
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., Peter Maydell, 2013/06/26
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., Jean-Christophe DUBOIS, 2013/06/26