[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 04/17] tests: adjust test-thread-pool to new
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v4 04/17] tests: adjust test-thread-pool to new aio_poll() semantics |
Date: |
Thu, 27 Jun 2013 15:16:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 14/06/2013 13:43, Stefan Hajnoczi ha scritto:
>
> -/* Wait until all aio and bh activity has finished */
> -static void qemu_aio_wait_all(void)
> -{
> - while (aio_poll(ctx, true)) {
> - /* Do nothing */
> - }
> -}
> -
> static void test_submit(void)
> {
> WorkerTestData data = { .n = 0 };
> thread_pool_submit(pool, worker_cb, &data);
> - qemu_aio_wait_all();
> + while (data.n == 0) {
> + aio_poll(ctx, true);
> + }
> g_assert_cmpint(data.n, ==, 1);
These will now loop forever for a bad thread_pool_submit that just
returns immediately. Slightly worse for debuggability, but
thread-pool.c is not expected to have big churn.
Reviewed-by: Paolo Bonzini <address@hidden>
- [Qemu-devel] [PATCH v4 00/17] aio: drop io_flush(), Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 01/17] block: stop relying on io_flush() in bdrv_drain_all(), Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 04/17] tests: adjust test-thread-pool to new aio_poll() semantics, Stefan Hajnoczi, 2013/06/14
- Re: [Qemu-devel] [PATCH v4 04/17] tests: adjust test-thread-pool to new aio_poll() semantics,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v4 06/17] block/curl: drop curl_aio_flush(), Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 07/17] block/gluster: drop qemu_gluster_aio_flush_cb(), Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 08/17] block/iscsi: drop iscsi_process_flush(), Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 09/17] block/linux-aio: drop qemu_laio_completion_cb(), Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 10/17] block/nbd: drop nbd_have_request(), Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 11/17] block/rbd: drop qemu_rbd_aio_flush_cb(), Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 02/17] dataplane/virtio-blk: check exit conditions before aio_poll(), Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 12/17] block/sheepdog: drop have_co_req() and aio_flush_request(), Stefan Hajnoczi, 2013/06/14
- [Qemu-devel] [PATCH v4 03/17] tests: adjust test-aio to new aio_poll() semantics, Stefan Hajnoczi, 2013/06/14