[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15 |
|
Date: |
Thu, 27 Jun 2013 11:26:20 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
On 06/17/2013 03:40 PM, Petar Jovanovic wrote:
> From: Petar Jovanovic <address@hidden>
>
> Multiplication of Q15 fractional halfword vectors was incorrect in the
> previous implementation of mipsdsp_rndq15_mul_q15_q15. It failed to take
> element signs into account. This change fixes it, and it adds a test case
> for it.
>
> The change also removes unnecessary cast in the function
> mipsdsp_mul_q15_q15_overflowflag21().
>
> Signed-off-by: Petar Jovanovic <address@hidden>
> ---
> target-mips/dsp_helper.c | 4 ++--
> tests/tcg/mips/mips32-dsp/mulq_rs_ph.c | 19 ++++++++++++++++++-
> 2 files changed, 20 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~