Re: [Qemu-devel] [PATCH v3] Add timestamp to error message

[Seiji Aguchi]

Thank you for the review.

> > +#include "qemu-common.h"
> > +
> > +/*  "1970-01-01T00:00:00.999999Z" + '\0' */
> > +#define TIMESTAMP_LEN 28
> 
> Self-documenting constants are nicer:
> 
> #define TIMESTAMP_LEN (sizeof("1970-01-01T00:00:00.999999Z")+1)

I will fix it.

> 
> extern void qemu_get_timestamp_str(char *timestr, size_t len)
> 
> where len is the length of timestr, and where the comments document that
> len should be at least TIMESTAMP_LEN to avoid truncation (or even
> assert() if it is not)?

I will fix as above.

> 
> > +++ b/qemu-options.hx
> > @@ -3102,3 +3102,15 @@ HXCOMM This is the last statement. Insert new 
> > options before this line!
> >  STEXI
> >  @end table
> >  ETEXI
> > +
> > +DEF("msg", HAS_ARG, QEMU_OPTION_msg,
> > +    "-msg [timestamp=on|off]\n"
> > +    "                output message with timestamp (default: off)\n",
> > +    QEMU_ARCH_ALL)
> 
> Did you test that the existing query-command-line-options QMP command
> will list this option (just making sure that libvirt will be able to
> know when to use this option).

I will test it in the next patch.

Seiji

> 
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org