Re: [Qemu-devel] [PATCH] kvmclock: clock should count only if vm is running (v2)

[Paolo Bonzini]

Il 25/06/2013 14:18, Gleb Natapov ha scritto:
> On Tue, Jun 18, 2013 at 08:38:25PM -0300, Marcelo Tosatti wrote:
>> > 
>> > v2: remove unnecessary runstate_is_running() usage (Paolo)
>> > 
>> > --
>> > 
>> > kvmclock should not count while vm is paused, because:
>> > 
>> > 1) if the vm is paused for long periods, timekeeping
>> > math can overflow while converting the (large) clocksource
>> > delta to nanoseconds.
>> > 
>> > 2) Users rely on CLOCK_MONOTONIC to count run time, that is,
>> > time which OS has been in a runnable state (see CLOCK_BOOTTIME).
>> > 
>> > Change kvmclock driver so as to save clock value when vm transitions
>> > from runnable to stopped state, and to restore clock value from stopped
>> > to runnable transition.
>> > 
>> > Signed-off-by: Marcelo Tosatti <address@hidden>
>
> Applied, thanks.

Cc: address@hidden

Gleb, the commit hash is fixed now that you applied the patch---so I
cannot just amend it to include the Cc, right?

Paolo