Re: [Qemu-devel] [PATCH v2] target-mips: fix mipsdsp_trunc16_sat16_round

[Richard Henderson]

On 06/30/2013 04:54 PM, Petar Jovanovic wrote:
> From: Petar Jovanovic <address@hidden>
> 
> This change corrects rounding and saturation of Q31 fractional value in
> mipsdsp_trunc16_sat16_round(). Overflow detection was incorrect for the
> corner case for PRECRQ_RS.PH, and this test case is also part of the change.
> 
> Signed-off-by: Petar Jovanovic <address@hidden>
> ---
> 
>  v2:
> 
>  - added comments to the code
> 
>  target-mips/dsp_helper.c                   |   16 +++++++++++-----
>  tests/tcg/mips/mips32-dsp/precrq_rs_ph_w.c |   24 ++++++++++++++++++++----
>  2 files changed, 31 insertions(+), 9 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~