qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH 0/4] per-object libraries


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [RFC PATCH 0/4] per-object libraries
Date: Mon, 01 Jul 2013 16:53:11 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6

Il 01/07/2013 16:46, Andreas Färber ha scritto:
>> > 
>> > What's wrong with a single makefile for everything, except
>> > of the need to use full pathnames from the top-level source
>> > dir?
> In short the problem we ran into was missing *.d inclusions.
> This got fixed by automatically expanding net/ to -include
> net/Makefile.objs and -include net/*.d or so.

I don't think that's the problem.  Simply I don't think that listing
1000 object files in a single makefile are manageable.  Choosing the
right directory per-target is also much easier if you can just do

        obj-y += hw/$(TARGET_BASE_ARCH)/

instead of long if-elseif-elseif-elseif-endif conditionals.

Conflicts in a small file are also way easier to solve, even if there
are more conflicting files.

If you prefer to have _everything_ in a single file, you just have to
post patches and justify them.  I just doubt that the result will be
better than what we have today, and the time would be better invested in
cleaning up what we have today.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]