[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2 01/11] iscsi: add logical block provisioning i
|
From: |
Peter Lieven |
|
Subject: |
Re: [Qemu-devel] [PATCHv2 01/11] iscsi: add logical block provisioning information to iscsilun |
|
Date: |
Mon, 1 Jul 2013 18:08:59 +0200 |
Am 01.07.2013 um 15:35 schrieb Stefan Hajnoczi <address@hidden>:
> On Thu, Jun 27, 2013 at 03:11:25PM +0200, Peter Lieven wrote:
>> @@ -1130,6 +1137,46 @@ static int iscsi_open(BlockDriverState *bs, QDict
>> *options, int flags)
>> bs->sg = 1;
>> }
>>
>> + if (iscsilun->lbpme) {
>> + struct scsi_inquiry_logical_block_provisioning *inq_lbp;
>> + int full_size;
>> +
>> + task = iscsi_inquiry_sync(iscsi, iscsilun->lun, 1,
>> +
>> SCSI_INQUIRY_PAGECODE_LOGICAL_BLOCK_PROVISIONING,
>> + 64);
>
> Does this leak the previous task from line 1101?
You are right. This is silently fixed in PATCH 2/11. I will put both patches in
one in v3.