[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC qom-cpu 24/41] target-alpha: Change DisasCon
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH RFC qom-cpu 24/41] target-alpha: Change DisasContext::env to CPUState |
Date: |
Mon, 01 Jul 2013 19:42:27 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 |
Am 01.07.2013 19:23, schrieb Richard Henderson:
> On 06/29/2013 01:01 PM, Andreas Färber wrote:
>> - CPUAlphaState *env;
>> + AlphaCPU *cpu;
>
> Actually, I take this back. I'd prefer that we simply pull out the two
> variables that we need and place them in the DisasContext. That's the way it
> should have been in the first place.
Fine with me. Do you want to send a patch based on master right away, or
should I do that in v2?
>> @@ -3394,7 +3394,7 @@ static inline void
>> gen_intermediate_code_internal(AlphaCPU *cpu,
>> gen_opc_end = tcg_ctx.gen_opc_buf + OPC_MAX_SIZE;
>>
>> ctx.tb = tb;
>> - ctx.env = env;
>> + ctx.cpu = alpha_env_get_cpu(env);
>
> This should have been ctx.cpu = cpu anyway, apparently fixed in the next
> patch.
Oops, I had done alpha first and then prepended the AlphaCPU propagation
alongside the other targets that needed it.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg