Re: [Qemu-devel] [PATCH v4 09/10] qemu-ga: install Windows VSS provider on `qemu-ga -s install'

[Tomoki Sekiyama]

On 7/1/13 10:50 , "Laszlo Ersek" <address@hidden> wrote:

>On 06/06/13 17:06, Tomoki Sekiyama wrote:
>>+#ifdef HAS_VSS_SDK
>> +                if (FAILED(COMRegister())) {
>> +                    return EXIT_FAILURE;
>> +                }
>
>COMRegister() seems to print error messages on failure, OK.
>
>> +#endif
>>                  return ga_install_service(path, log_filepath,
>>fixed_state_dir);
>
>Shouldn't you call COMUnregister() if ga_install_service() fails?
>Otherwise we might end up with a half-installed service (COM app catalog
>entry for VSS provider: yes, VSS provider DLL: yes, VSS client / qemu-ga
>service: no).

Agreed. I will fix this.

Thanks,
Tomoki Sekiyama