|
| From: | Richard Henderson |
| Subject: | Re: [Qemu-devel] [PATCH RFC qom-cpu 41/41] cpu: Introduce CPUClass::gdb_{read, write}_register() |
| Date: | Mon, 01 Jul 2013 11:07:31 -0700 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 06/29/2013 01:01 PM, Andreas Färber wrote: > Replace GET_REG*() macros by gdb_get_reg*() inline functions for > clarity and drop breaks after return. > > Allows to move target-specific code to new target-*/gdbstub.c files. > > Signed-off-by: Andreas Färber <address@hidden> This one's quite hard to read. I wonder if there's value in splitting out functions one target at a time into the new gdbstub.c files, and only afterward performing a few minor textual changes to transform those functions into the CPUClass methods? r~
| [Prev in Thread] | Current Thread | [Next in Thread] |