[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 06/11] memory: add ref/unref calls
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 06/11] memory: add ref/unref calls |
|
Date: |
Tue, 02 Jul 2013 11:28:32 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 02/07/2013 10:36, Jan Kiszka ha scritto:
>>> >> Hmm, two solutions for one problem - can we improve this in the next
>>> >> round?
>> >
>> > Sure, I can adapt the hw/acpi/piix4.c to use ifs in the same style as
>> > hw/isa/lpc_ich9.c (I find the code easier to read).
> I was more referring to memory_region_present vs. open-coding.
Understood, but once you replace ?: with "if", the memory_region_present
wrapper loses most of the appeal. So I actually prefer the open-coded one.
Paolo