qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] target-openrisc: Add typename for CPU models.


From: Jia Liu
Subject: Re: [Qemu-devel] [PATCH] target-openrisc: Add typename for CPU models.
Date: Tue, 2 Jul 2013 17:29:05 +0800

Hi Dongxue,

On Tue, Jul 2, 2013 at 5:11 PM, Dongxue Zhang <address@hidden> wrote:
>
> Make target-openrisc running OK by add typename in openrisc_cpu_class_by_name().
>
> Signed-off-by: Dongxue Zhang <address@hidden>
> ---
>  target-openrisc/cpu.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c
> index fd90d37..d38c28b 100644
> --- a/target-openrisc/cpu.c
> +++ b/target-openrisc/cpu.c
> @@ -96,12 +96,14 @@ static void openrisc_cpu_initfn(Object *obj)
>  static ObjectClass *openrisc_cpu_class_by_name(const char *cpu_model)
>  {
>      ObjectClass *oc;
> +    char *typename;
>
>      if (cpu_model == NULL) {
>          return NULL;
>      }
>
> -    oc = object_class_by_name(cpu_model);
> +    typename = g_strdup_printf("%s-" TYPE_OPENRISC_CPU, cpu_model);
> +    oc = object_class_by_name(typename);
>      if (oc != NULL && (!object_class_dynamic_cast(oc, TYPE_OPENRISC_CPU) ||
>                         object_class_is_abstract(oc))) {
>          return NULL;

Thanks for your fix, it looks and test good to me.

>
> --
> 1.8.1.2
>
>

Regards,
Jia

reply via email to

[Prev in Thread] Current Thread [Next in Thread]