[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 06/11] memory: add ref/unref calls
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 06/11] memory: add ref/unref calls |
|
Date: |
Tue, 02 Jul 2013 11:31:59 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2013-07-02 11:28, Paolo Bonzini wrote:
> Il 02/07/2013 10:36, Jan Kiszka ha scritto:
>>>>>> Hmm, two solutions for one problem - can we improve this in the next
>>>>>> round?
>>>>
>>>> Sure, I can adapt the hw/acpi/piix4.c to use ifs in the same style as
>>>> hw/isa/lpc_ich9.c (I find the code easier to read).
>> I was more referring to memory_region_present vs. open-coding.
>
> Understood, but once you replace ?: with "if", the memory_region_present
> wrapper loses most of the appeal. So I actually prefer the open-coded one.
Well, count the memory_region_unref calls.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux