qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] spapr: Fix compiler warnings for some versio


From: Alexander Graf
Subject: Re: [Qemu-devel] [PATCH v2] spapr: Fix compiler warnings for some versions of gcc
Date: Tue, 02 Jul 2013 14:42:56 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20120306 Thunderbird/10.0.3

On 06/29/2013 03:47 PM, Stefan Weil wrote:
i686-w64-mingw32-gcc (GCC) 4.6.3 from Debian wheezy reports these warnings:

hw/ppc/spapr_hcall.c:188:1: warning:
  control reaches end of non-void function [-Wreturn-type]

hw/ppc/spapr_pci.c:454:1: warning:
  control reaches end of non-void function [-Wreturn-type]

Both warnings are fixed by using g_assert_not_reached instead of assert.
A second line with assert(0) in spapr_pci.c which did not raise a compiler
warning was modified, too, because g_assert_not_reached documents the
purpose of that statement and is not removed in release builds.

Signed-off-by: Stefan Weil<address@hidden>

Thanks, applied to ppc-next.


Alex




reply via email to

[Prev in Thread] Current Thread [Next in Thread]