Re: [Qemu-devel] [PATCH v3] linux-user: improve target_to_host_sock_type conversion

[Peter Maydell]

On 2 July 2013 15:13, Petar Jovanovic <address@hidden> wrote:
> Yet, I ended up changing 80% of the header file with this version, so I
> was under impression it makes sense to change the remaining 20%.

Yeah, that's fine -- but once you get to that scale of change it's
nicer to have patch 1/2 fix formatting, patch 2/2 actual change.
(Just a note for next time at this point, though.)

>> Not using the same base as the kernel (hex vs octal) made checking
>> the values a bit tedious too, but I think they're all correct.
>
> What values are you refering to?

arch/sparc/include/uapi/asm/fcntl.h:#define O_CLOEXEC   0x400000
arch/alpha/include/asm/socket.h:#define SOCK_NONBLOCK   0x40000000
arch/mips/include/uapi/asm/fcntl.h:#define O_NONBLOCK   0x0080
arch/sparc/include/uapi/asm/fcntl.h:#define O_NONBLOCK  0x4000

thanks
-- PMM