Re: [Qemu-devel] [PATCH v5] Add timestamp to error_report()

[Seiji Aguchi]

> Patches need to make sense today, please do not add extra code with
> potential future use in mind:
> 
> 1. Other developers must be able to read and modify the current codebase
>    on its own.  They do not know what potential future changes you were
>    thinking about.
> 
> 2. You may never end up submitting or getting the future stuff upstream.
>    Then we'd be left with extra layers that are never used.

I understand what you are concerned.
I will remove utils/qemu-time.c and its header file.

> Daniel's statement was about the code you copied from libvirt.  It was
> not about using the glib function, which simplifies things greatly and
> avoids the need for a test suite.

Honestly, I still think it is reasonable to introduce the common time-handling 
functionality.
You seem to say that using the glib function is simple, so we don't need to 
introduce 
the common functionality. 

However, "commonly useful" is not related whether it is simple or not.
 I'm concerned that we may duplicate same code by "focusing on today  too much".

But, I don't stick to my opinion on this patch.

Seiji