[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/17] block: expect errors from bdrv_co_is_allo
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 06/17] block: expect errors from bdrv_co_is_allocated |
Date: |
Fri, 05 Jul 2013 12:28:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 05/07/2013 11:19, Stefan Hajnoczi ha scritto:
> > /* If the cluster is allocated, we don't need to take action */
> > ret = bdrv_is_allocated(bs, sector, n, &n);
> > + if (ret < 0) {
> > + error_report("error while reading from file");
> > + goto out;
> > + }
>
> We should print the errno valid and saying "while reading from file" is
> a little misleading:
>
> "error while checking cluster allocation status: %d", ret
I think this is too specific. In the end, errors from bdrv_is_allocated
are almost always due to a problem reading the metadata from the file.
I will change it to "error reading image metadata", or something like that.
(And also use strerror).
Paolo
- Re: [Qemu-devel] [PATCH 01/17] cow: make reads go at a decent speed, (continued)
- [Qemu-devel] [PATCH 02/17] cow: make writes go at a less indecent speed, Paolo Bonzini, 2013/07/03
- [Qemu-devel] [PATCH 03/17] cow: do not call bdrv_co_is_allocated, Paolo Bonzini, 2013/07/03
- [Qemu-devel] [PATCH 04/17] block: make bdrv_co_is_allocated static, Paolo Bonzini, 2013/07/03
- [Qemu-devel] [PATCH 05/17] block: remove bdrv_is_allocated_above/bdrv_co_is_allocated_above distinction, Paolo Bonzini, 2013/07/03
- [Qemu-devel] [PATCH 07/17] qemu-img: always probe the input image for allocated sectors, Paolo Bonzini, 2013/07/03
- [Qemu-devel] [PATCH 06/17] block: expect errors from bdrv_co_is_allocated, Paolo Bonzini, 2013/07/03
- [Qemu-devel] [PATCH 08/17] block: make bdrv_has_zero_init return false for copy-on-write-images, Paolo Bonzini, 2013/07/03
- [Qemu-devel] [PATCH 09/17] block: introduce bdrv_get_block_status API, Paolo Bonzini, 2013/07/03
- [Qemu-devel] [PATCH 10/17] block: define get_block_status return value, Paolo Bonzini, 2013/07/03
[Qemu-devel] [PATCH 12/17] qemu-img: add a "map" subcommand, Paolo Bonzini, 2013/07/03