Re: [Qemu-devel] [PATCH V4 00/10] Add support for binding guest numa nodes to host numa nodes

[Eduardo Habkost]

On Thu, Jul 04, 2013 at 05:53:07PM +0800, Wanlong Gao wrote:
[...]
> Bandan Das (1):
>   NUMA: Support multiple CPU ranges on -numa option
> 
> Wanlong Gao (9):
>   NUMA: Add numa_info structure to contain numa nodes info
>   NUMA: Add Linux libnuma detection
>   NUMA: parse guest numa nodes memory policy
>   NUMA: handle Error in cpus, mpol and hostnode parser
>   NUMA: split out the common range parser
>   NUMA: set guest numa nodes memory policy
>   NUMA: add qmp command set-mpol to set memory policy for NUMA node
>   NUMA: add hmp command set-mpol
>   NUMA: show host memory policy info in info numa command

checkpatch.pl issues:


total: 0 errors, 0 warnings, 155 lines checked

/tmp/numav4-fp/0001-NUMA-Support-multiple-CPU-ranges-on-numa-option.patch has 
no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 129 lines checked

/tmp/numav4-fp/0002-NUMA-Add-numa_info-structure-to-contain-numa-nodes-i.patch 
has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 68 lines checked

/tmp/numav4-fp/0003-NUMA-Add-Linux-libnuma-detection.patch has no obvious style 
problems and is ready for submission.
WARNING: braces {} are necessary for all arms of this statement
#106: FILE: vl.c:1424:
+    if (parse_uint(hostnode, &value, &endptr, 10) < 0)
[...]

WARNING: braces {} are necessary for all arms of this statement
#129: FILE: vl.c:1447:
+    if (clear)
[...]
+    else
[...]

total: 0 errors, 2 warnings, 158 lines checked

/tmp/numav4-fp/0004-NUMA-parse-guest-numa-nodes-memory-policy.patch has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 108 lines checked

/tmp/numav4-fp/0005-NUMA-handle-Error-in-cpus-mpol-and-hostnode-parser.patch 
has no obvious style problems and is ready for submission.
WARNING: suspect code indent for conditional statements (8, 11)
#47: FILE: vl.c:1351:
+        if (parse_uint_full(endptr + 1, endvalue, 10) < 0) {
+           return -1;

total: 0 errors, 1 warnings, 128 lines checked

/tmp/numav4-fp/0006-NUMA-split-out-the-common-range-parser.patch has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
WARNING: braces {} are necessary for all arms of this statement
#100: FILE: cpus.c:1225:
+    if (block->host == NULL)
[...]

total: 0 errors, 1 warnings, 105 lines checked

/tmp/numav4-fp/0007-NUMA-set-guest-numa-nodes-memory-policy.patch has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 113 lines checked

/tmp/numav4-fp/0008-NUMA-add-qmp-command-set-mpol-to-set-memory-policy-f.patch 
has no obvious style problems and is ready for submission.
total: 0 errors, 0 warnings, 66 lines checked

/tmp/numav4-fp/0009-NUMA-add-hmp-command-set-mpol.patch has no obvious style 
problems and is ready for submission.
WARNING: braces {} are necessary for all arms of this statement
#70: FILE: monitor.c:1848:
+        if (numa_info[i].flags & NODE_HOST_RELATIVE)
[...]

WARNING: braces {} are necessary for all arms of this statement
#76: FILE: monitor.c:1854:
+            if (next == numa_max_node())
[...]

WARNING: braces {} are necessary for all arms of this statement
#80: FILE: monitor.c:1858:
+            if (next > numa_max_node() || next == MAX_CPUMASK_BITS)
[...]

total: 0 errors, 3 warnings, 60 lines checked

/tmp/numav4-fp/0010-NUMA-show-host-memory-policy-info-in-info-numa-comma.patch 
has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

-- 
Eduardo