[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/9] linux-user: fix segmentation fault passing
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 1/9] linux-user: fix segmentation fault passing with h2g(x) != x |
Date: |
Sat, 6 Jul 2013 11:27:45 +0100 |
On 6 July 2013 01:36, Alexander Graf <address@hidden> wrote:
> When forwarding a segmentation fault into the guest process, we were passing
> the host's address directly into the guest process's signal descriptor.
>
> That obviously confused the guest process, since it didn't know what to make
> of the (usually 32-bit truncated) address. Passing in h2g(address) makes the
> guest process a lot happier.
Commit message says it uses h2g, code doesn't. Maybe we should have
an h2g_unchecked() for this sort of use?
thanks
-- PMM