Re: [Qemu-devel] [PATCH 28/66] exec: reorganize address_space_map

[Peter Maydell]

On 4 July 2013 16:13, Paolo Bonzini <address@hidden> wrote:
> -    rlen = todo;
> -    ret = qemu_ram_ptr_length(raddr, &rlen);
> -    *plen = rlen;
> -    return ret;
> +
> +    *plen = done;
> +    return qemu_ram_ptr_length(raddr + base, plen);

This change provokes a warning from clang on MacOSX:

  CC    arm-softmmu/exec.o
/Users/pm215/src/qemu/exec.c:2164:46: warning: incompatible pointer
types passing 'hwaddr *' (aka 'unsigned long long *') to parameter
      of type 'ram_addr_t *' (aka 'unsigned long *')
[-Wincompatible-pointer-types]
    return qemu_ram_ptr_length(raddr + base, plen);
                                             ^~~~
/Users/pm215/src/qemu/exec.c:1392:63: note: passing argument to
parameter 'size' here
static void *qemu_ram_ptr_length(ram_addr_t addr, ram_addr_t *size)
                                                              ^
1 warning generated.

I'll cook up a patch...

thanks
-- PMM