[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 18/19] target-ppc: Enhance the CPU node labels f
From: |
Prerna Saxena |
Subject: |
Re: [Qemu-devel] [PATCH 18/19] target-ppc: Enhance the CPU node labels for the guest device tree for pseries. |
Date: |
Mon, 08 Jul 2013 21:19:03 +0530 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
On 07/08/2013 02:32 PM, Andreas Färber wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am 08.07.2013 03:09, schrieb David Gibson:
>> On Sat, Jul 06, 2013 at 11:54:15PM +1000, Alexey Kardashevskiy
>> wrote:
>>> @@ -1342,6 +1346,13 @@ static void
>>> ppc_spapr_init(QEMUMachineInitArgs *args)
>>> register_savevm_live(NULL, "spapr/htab", -1, 1,
>>> &savevm_htab_handlers, spapr);
>>>
>>> + /* Ensure that cpu_model is correctly reflected for a KVM
>>> guest */ + if (kvm_enabled() && !strcmp(cpu_model, "host")) {
>>> + asm ("mfpvr %0" + : "=r"(pvr)); +
>>> cpu_model = ppc_cpu_alias_by_pvr(pvr);
>>
>> This needs to be protected by an ifdef CONFIG_KVM or similar. If
>> the compiler optimization level is turned down, so that it doesn't
>> recognize that the kvm_enabled() is always false, then this could
>> attempt to compile the ppc asm instructions on an x86 (or
>> whatever) host.
>
> This hunk can be completely replaced by QOM mechanisms - just didn't
> get to replying yet...
>
Hi Andreas,
Sorry I already sent out a v2, and only then saw your message. Could you
pls explain how I could use QOM to replace this code block ?
Regards,
--
Prerna Saxena
Linux Technology Centre,
IBM Systems and Technology Lab,
Bangalore, India
- [Qemu-devel] [PATCH 12/19] pseries: savevm support for pseries machine, (continued)
- [Qemu-devel] [PATCH 12/19] pseries: savevm support for pseries machine, Alexey Kardashevskiy, 2013/07/06
- [Qemu-devel] [PATCH 13/19] pseries: savevm support for PCI host bridge, Alexey Kardashevskiy, 2013/07/06
- [Qemu-devel] [PATCH 14/19] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN, Alexey Kardashevskiy, 2013/07/06
- [Qemu-devel] [PATCH 15/19] pseries: Support for in-kernel XICS interrupt controller, Alexey Kardashevskiy, 2013/07/06
- [Qemu-devel] [PATCH 16/19] pseries: savevm support with KVM, Alexey Kardashevskiy, 2013/07/06
- [Qemu-devel] [PATCH 17/19] target-ppc: Add POWER8 v1.0 CPU model, Alexey Kardashevskiy, 2013/07/06
- [Qemu-devel] [PATCH 18/19] target-ppc: Enhance the CPU node labels for the guest device tree for pseries., Alexey Kardashevskiy, 2013/07/06
- [Qemu-devel] [PATCH v2 18/19] target-ppc: Enhance the CPU node labels for the guest device tree for pseries., Prerna Saxena, 2013/07/08
[Qemu-devel] [PATCH 19/19] spapr-pci: rework MSI/MSIX, Alexey Kardashevskiy, 2013/07/06
[Qemu-devel] [PATCH 08/19] pseries: savevm support for PAPR VIO logical tty, Alexey Kardashevskiy, 2013/07/06
Re: [Qemu-devel] [PATCH 00/19 v4] spapr: migration, pci, msi, power8, Anthony Liguori, 2013/07/29