Re: [Qemu-devel] [PATCH v3 2/2] display: stop using DT_NOGRAPHIC, use DT_NONE

[Peter Maydell]

On 3 July 2013 17:29, Michael Tokarev <address@hidden> wrote:
> It looks like initially there was -nographic option to turn
> off display, now there's another option of the same sort,
> -display none.  But code in other places of qemu checks for
> DT_NOGRAPHIC and does not work well with -display none.
> Make DT_NOGRAPHIC an internal version which selects DT_NONE,
> and check for that in all other places where previously we
> checked for DT_NOGRAPHIC.
>
> While at it, rename two private variants of display (DT_DEFAULT
> and DT_NOGRAPHIC) to use two underscores and make them negative,
> and set DT_NONE to 0.
>
> This should fix the issue of non-working sun serial console
> with the suggested replacement of -nographic which is
> -display none.
>
> Cc: Todd T. Fries <address@hidden>
> Signed-off-by: Michael Tokarev <address@hidden>

Reviewed-by: Peter Maydell <address@hidden>

I tested, and this retains the current behaviour for the
two use cases I care about (-display none -serial stdio
vs -nographic).

thanks
-- PMM