[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] s390: Implement dump-guest-memory support fo
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH v4] s390: Implement dump-guest-memory support for target s390x |
Date: |
Wed, 10 Jul 2013 12:37:17 +0200 |
On 10.07.2013, at 12:27, Christian Borntraeger wrote:
> On 05/07/13 14:02, Jens Freimann wrote:
>> With this patch dump-guest-memory on s390 produces an ELF formatted,
>> crash-readable dump.
>> In order to implement this, the arch-specific part of dump-guest-memory
>> was added:
>> target-s390x/arch_dump.c contains the whole set of function for writing
>> Elf note sections of all types for s390x.
>>
>> Signed-off-by: Ekaterina Tumanova <address@hidden>
>> Signed-off-by: Jens Freimann <address@hidden>
> Acked-by: Christian Borntraeger <address@hidden>
>
> I can confirm that this patch creates proper dumps readable by crash with
> valid
> memory and valid register content. Would be good to see this upstream.
>
> Meanwhile this patch no longer cleanly applies due to
> commit 878096eeb278a8ac1ccd6667af73e026f29b4cf5
> cpu: Turn cpu_dump_{state,statistics}() into CPUState hooks
>
> The fixup is trivial.
> Alex, please apply.
I'd like to get an Ack from Andreas too :). But then I'll happily apply it.
Alex