qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 09/43] cpu: Make first_cpu and next_cpu CPUState


From: Andreas Färber
Subject: Re: [Qemu-devel] [PULL 09/43] cpu: Make first_cpu and next_cpu CPUState
Date: Thu, 11 Jul 2013 11:55:43 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7

Am 11.07.2013 11:14, schrieb TeLeMan:
> On Wed, Jul 10, 2013 at 10:33 PM, Andreas Färber <address@hidden> wrote:
>> diff --git a/gdbstub.c b/gdbstub.c
>> index f7d9f13..0ee82a9 100644
>> --- a/gdbstub.c
>> +++ b/gdbstub.c
[...]
>> @@ -2394,7 +2401,7 @@ static int gdb_handle_packet(GDBState *s, const char 
>> *line_buf)
>>              put_packet(s, "QC1");
>>              break;
>>          } else if (strcmp(p,"fThreadInfo") == 0) {
>> -            s->query_cpu = first_cpu;
>> +            s->query_cpu = first_cpu->env_ptr;
>>              goto report_cpuinfo;
>>          } else if (strcmp(p,"sThreadInfo") == 0) {
>>          report_cpuinfo:
>> @@ -2402,7 +2409,7 @@ static int gdb_handle_packet(GDBState *s, const char 
>> *line_buf)
>>                  snprintf(buf, sizeof(buf), "m%x",
>>                           cpu_index(ENV_GET_CPU(s->query_cpu)));
>>                  put_packet(s, buf);
>> -                s->query_cpu = s->query_cpu->next_cpu;
>> +                s->query_cpu = ENV_GET_CPU(s->query_cpu)->next_cpu->env_ptr;
> next_cpu may be NULL.

True. If this is the only place where you've found that mistake then the
implicit fix is already queued next on qom-cpu:
http://patchwork.ozlabs.org/patch/255756/

Review and/or testing of the remaining gdbstub patches would be appreciated:
http://lists.nongnu.org/archive/html/qemu-devel/2013-07/msg01510.html
Mainly I'm waiting on an ack or feedback for the vaddr typedef to proceed.

Thanks,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]