[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 05/11] qapi: Add visitor for implicit struct
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC PATCH 05/11] qapi: Add visitor for implicit structs |
Date: |
Thu, 11 Jul 2013 06:51:03 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 07/11/2013 06:41 AM, Eric Blake wrote:
> On 07/09/2013 03:53 AM, Kevin Wolf wrote:
>> These can be used when an embedded struct is parsed and members not
>> belonging to the struct may be present in the input (parsing flat
>> namespect QMP union with discriminator)
>
> namespect? Not sure if you meant 'namespaced'?
>
> Again, a comment demonstrating in sample QMP on what this is attempting
> would be helpful in the commit message. Without looking at later
> patches yet,
Now that I've read the commit message of patch 6/11, may I suggest
something along the lines of this wording:
Add a new visitor that allows parsing of an implicit struct, which is
created by inlining the namespace of the nested union 'data' struct into
the top-level struct of the union itself.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [RFC PATCH 01/11] qapi-types.py: Split off generate_struct_fields(), (continued)
- [Qemu-devel] [RFC PATCH 03/11] qapi-visit.py: Split off generate_visit_struct_fields(), Kevin Wolf, 2013/07/09
- [Qemu-devel] [RFC PATCH 04/11] qapi-visit.py: Implement 'base' for unions, Kevin Wolf, 2013/07/09
- [Qemu-devel] [RFC PATCH 02/11] qapi-types.py: Implement 'base' for unions, Kevin Wolf, 2013/07/09
- [Qemu-devel] [RFC PATCH 05/11] qapi: Add visitor for implicit structs, Kevin Wolf, 2013/07/09
- [Qemu-devel] [RFC PATCH 06/11] qapi: Flat unions with arbitrary discriminator, Kevin Wolf, 2013/07/09
- [Qemu-devel] [RFC PATCH 09/11] Implement qdict_flatten(), Kevin Wolf, 2013/07/09
- [Qemu-devel] [RFC PATCH 07/11] qapi: Add consume argument to qmp_input_get_object(), Kevin Wolf, 2013/07/09
- [Qemu-devel] [RFC PATCH 08/11] qapi: Anonymous unions, Kevin Wolf, 2013/07/09